Skip to content

gh-114058: Improve method information in redundancy eliminator#115848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Fidget-Spinner merged 3 commits into from
Feb 23, 2024
Merged

gh-114058: Improve method information in redundancy eliminator #115848

Fidget-Spinner merged 3 commits into from
Feb 23, 2024

Conversation

@Fidget-Spinner
Copy link
Member

@Fidget-SpinnerFidget-Spinner commented Feb 23, 2024•
edited by bedevere-app bot
Loading

@bedevere-appbedevere-appbot mentioned this pull request Feb 23, 2024
Closed
@Fidget-Spinner
Copy link
MemberAuthor

Fidget-Spinner commented Feb 23, 2024

Addresses @markshannon 's reviews in #115779 (comment).

@Fidget-SpinnerFidget-Spinner mentioned this pull request Feb 23, 2024
Closed
markshannon
markshannon requested changes Feb 23, 2024
View reviewed changes
Copy link
Member

@markshannonmarkshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you can remove sym_is_not_null

@bedevere-app
Copy link

bedevere-appbot commented Feb 23, 2024

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@Fidget-Spinner
Copy link
MemberAuthor

Fidget-Spinner commented Feb 23, 2024

I have made the requested changes; please review again

markshannon
markshannon approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@markshannonmarkshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Fidget-SpinnerFidget-Spinner merged commit 2ec50b4 into python:mainFeb 23, 2024
@Fidget-SpinnerFidget-Spinner deleted the improve_methods branch February 23, 2024 15:41
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@Fidget-Spinner@woodruffw
pythongh-114058: Improve method information in redundancy eliminator (p…
9346fe0
…ythonGH-115848)
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@Fidget-Spinner@diegorusso
pythongh-114058: Improve method information in redundancy eliminator (p…
0e942e5
…ythonGH-115848)
LukasWoodtli pushed a commit to LukasWoodtli/cpython that referenced this pull request Jan 22, 2025
@Fidget-Spinner@LukasWoodtli
pythongh-114058: Improve method information in redundancy eliminator (p…
c6721f6
…ythonGH-115848)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannonmarkshannonmarkshannon approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Fidget-Spinner@markshannon