Skip to content

Conversation

@sobolevn
Copy link
Member

@sobolevnsobolevn commented Mar 5, 2024

Copy link
Member

@gvanrossumgvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No warnings on macOS.

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would not be more natural to use the %zd format string?

And this looks like a completely different issue than the originally reported one.

@ericsnowcurrently
Copy link
Member

Would not be more natural to use the %zd format string?

Yeah, that was a copy-paste failure on my part. I shouldn't have used PRId64 for _queue.count since it is Py_ssize_t, not int64_t. Using %zd sounds right.

And this looks like a completely different issue than the originally reported one.

This is a fix for my fix (gh-116369) for that originally reported issue.

@bedevere-app
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

Copy link
Member

@ericsnowcurrentlyericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sobolevn
Copy link
MemberAuthor

Thanks for the help and reviews!

@ericsnowcurrently
Copy link
Member

Thanks for fixing this. 😄

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@sobolevn@ericsnowcurrently@gvanrossum@serhiy-storchaka