Skip to content

gh-116439: Ensure thread is joined in test_empty_authkey#116442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
colesbury wants to merge 1 commit into from
Closed

gh-116439: Ensure thread is joined in test_empty_authkey #116442

colesbury wants to merge 1 commit into from

Conversation

@colesbury
Copy link
Contributor

@colesburycolesbury commented Mar 6, 2024•
edited by bedevere-app bot
Loading

The "dangling" thread can lead to "ENV CHANGED" test failures.

@colesburycolesbury added tests Tests in the Lib/test dir skip news labels Mar 6, 2024
@colesburycolesbury requested a review from gpshead as a code ownerMarch 6, 2024 21:39
@bedevere-appbedevere-appbot mentioned this pull request Mar 6, 2024
Closed
@colesbury
Copy link
ContributorAuthor

colesbury commented Mar 6, 2024

Oops, already fixed in #116434... what timing

@colesburycolesbury deleted the gh-116439-authkey branch March 6, 2024 21:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaAwaiting requested review from serhiy-storchaka

@gpsheadgpsheadAwaiting requested review from gpsheadgpshead is a code owner

Assignees

No one assigned

Labels

awaiting core reviewskip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@colesbury