GH-113710: Fix optimization of globals using _CHECK_FUNCTION#116460
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Closed
Member
Fidget-Spinner commented Mar 7, 2024
lgtm but I will wait for Guido to review too |
Fidget-Spinner approved these changes Mar 7, 2024
| assert(((PyFunctionObject *)frame->f_funcobj)->func_globals == globals); | ||
| PyFunctionObject *function = (PyFunctionObject *)frame->f_funcobj; | ||
| assert(PyFunction_Check(function)); | ||
| assert(function->func_builtins == builtins); |
There was a problem hiding this comment.
Note: these are read-only attributes so this precondition should hold.
brandtbucher approved these changes Mar 8, 2024
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#116410 added an obvious bug: I didn't update the pointers used.
But there is more subtle bug: Using pointers rather than version numbers risks a new function appearing to be the old one.
This PR fixes both bugs.