gh-113538: Allow client connections to be closed#116784
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Give applications the option of more forcefully terminating client connections for asyncio servers. Useful when terminating a service and there is limited time to wait for clients to finish up their work.
We want to be able to detect if the application fails to keep track of the transports, so we cannot keep them alive by using a hard reference.
The application might be waiting for all transports to close, so we need to properly inform the server that this transport is done.
One could be made clearar, and the other is probably superfluous.
Try to get the streams and the kernel in to a more deterministic state by specifying fixed buffering limits.
No possibly infinite loop. Instead ask the system how much buffer space it has and fill that.
In case it takes some time, as we need access to the server side stream objects to perform the test.
CendioOssman requested review from 1st1, asvetlov, gvanrossum, kumaraditya303 and willingc as code owners
ContributorAuthor
CendioOssman commented Mar 14, 2024
@gvanrossum, this should hopefully be more stable. |
gvanrossum approved these changes Mar 18, 2024
Member
gvanrossum left a comment
gvanrossum left a comment There was a problem hiding this comment.
LGTM, this looks like the right solution.
vstinner pushed a commit to vstinner/cpython that referenced this pull request Mar 20, 2024
…on#116784) These give applications the option of more forcefully terminating client connections for asyncio servers. Useful when terminating a service and there is limited time to wait for clients to finish up their work. This is a do-over with a test fix for pythongh-114432, which was reverted.
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
…on#116784) These give applications the option of more forcefully terminating client connections for asyncio servers. Useful when terminating a service and there is limited time to wait for clients to finish up their work. This is a do-over with a test fix for pythongh-114432, which was reverted.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
…on#116784) These give applications the option of more forcefully terminating client connections for asyncio servers. Useful when terminating a service and there is limited time to wait for clients to finish up their work. This is a do-over with a test fix for pythongh-114432, which was reverted.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a new attempt at #114432, with one additional commit to fix unreliably tests.
📚 Documentation preview 📚: https://cpython-previews--116784.org.readthedocs.build/