gh-113317: Move Argument Clinic converters to sub-modules#116836
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Move the following classes to new sub-modules: * libclinic.return_converters: * CReturnConverterAutoRegister * CReturnConverter * libclinic.int_converters: * bool_converter * char_converter * unsigned_char_converter * byte_converter * short_converter * unsigned_short_converter * int_converter * unsigned_int_converter * long_converter * unsigned_long_converter * long_long_converter * unsigned_long_long_converter * Py_ssize_t_converter * slice_index_converter * size_t_converter * libclinic.obj_converters: * fildes_converter * float_converter * double_converter * Py_complex_converter * object_converter * buffer * rwbuffer * robuffer * str_converter * PyBytesObject_converter * PyByteArrayObject_converter * unicode_converter * Py_UNICODE_converter * Py_buffer_converter * libclinic.misc_converters: * defining_class_converter * self_converter Move also Null, NULL and TypeSet to libclinic.utils. Add create_python_parser_namespace() for PythonParser to pass names to exec(). Fix --converters command in run_clinic(). Don't use dir(clinic) to list converters, but use 'converters' and 'return_converters' dictionaries instead.
vstinnerforce-pushed the clinic_converters branch from ee8d49d to b092a9bCompareSign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the following classes to new sub-modules:
libclinic.return_converters:
libclinic.int_converters:
libclinic.obj_converters:
libclinic.misc_converters:
Move also Null, NULL and TypeSet to libclinic.utils.