Skip to content

gh-112536: Add TSAN builds on Github Actions#116872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pitrou merged 28 commits into from
Mar 16, 2024
Merged

gh-112536: Add TSAN builds on Github Actions #116872

pitrou merged 28 commits into from
Mar 16, 2024

Conversation

@corona10
Copy link
Member

@corona10corona10 commented Mar 15, 2024•
edited by bedevere-app bot
Loading

@bedevere-appbedevere-appbot mentioned this pull request Mar 15, 2024
Closed
@pitroupitrou mentioned this pull request Mar 15, 2024
Merged
pitrou
pitrou reviewed Mar 15, 2024
View reviewed changes
pitrou
pitrou reviewed Mar 15, 2024
View reviewed changes
pitrou
pitrou reviewed Mar 15, 2024
View reviewed changes
@pitrou
Copy link
Member

pitrou commented Mar 15, 2024

Ah, yeah, "ThreadSanitizer: unexpected memory mapping" is due to a recent kernel update.
You need this workaround:
https://github.com/apache/arrow/blob/00a48217e93bea1e84f10dbfdf3c0c93dfe1ea3d/dev/tasks/docker-tests/github.linux.yml#L38-L39

@corona10corona10 marked this pull request as ready for review March 15, 2024 18:50
@corona10corona10 requested a review from colesburyMarch 15, 2024 18:50
@corona10
Copy link
MemberAuthor

corona10 commented Mar 16, 2024

In another PR we should add more tests to --tsan, because there are currently very few of them.

Yeah, yeah, I agree; this is just the initial setup; we need to do more tests for better coverage.

@corona10corona10 requested a review from vsajip as a code ownerMarch 16, 2024 01:36
pitrou
pitrou approved these changes Mar 16, 2024
View reviewed changes
Copy link
Member

@pitroupitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition! Thank you @corona10 !

@pitroupitrou changed the title gh-112536: Setting up TSAN test at Github Actiongh-112536: Add TSAN builds on Github ActionsMar 16, 2024
@pitroupitrou merged commit 20578a1 into python:mainMar 16, 2024
@corona10corona10 deleted the gh-112536-ci branch March 16, 2024 10:15
@itamaro
Copy link
Contributor

itamaro commented Mar 16, 2024

Are there buildbots for this configuration too?

@pitrou
Copy link
Member

pitrou commented Mar 16, 2024•
edited
Loading

No, just GHA AFAIK.

@bedevere-app
Copy link

bedevere-appbot commented Mar 18, 2024

GH-116953 is a backport of this pull request to the 3.12 branch.

pitrou pushed a commit to pitrou/cpython that referenced this pull request Mar 18, 2024
@corona10@pitrou
[3.12]pythongh-112536: Add TSAN builds on Github Actions (pythonGH-1…
0be64cb
…16872) (cherry picked from commit 20578a1) Co-authored-by: Donghee Na <donghee.na@python.org>
@bedevere-app
Copy link

bedevere-appbot commented Mar 18, 2024

GH-116953 is a backport of this pull request to the 3.12 branch.

pitrou added a commit that referenced this pull request Mar 18, 2024
@pitrou@corona10
[3.12]gh-112536: Add TSAN build on Github Actions (GH-116872)
25243b1
(cherry picked from commit 20578a1) Co-authored-by: Donghee Na <donghee.na@python.org>
vstinner pushed a commit to vstinner/cpython that referenced this pull request Mar 20, 2024
@corona10@vstinner
pythongh-112536: Add TSAN builds on Github Actions (python#116872)
ba70b85
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@corona10@adorilson
pythongh-112536: Add TSAN builds on Github Actions (python#116872)
2234f3e
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@corona10@diegorusso
pythongh-112536: Add TSAN builds on Github Actions (python#116872)
5ed7bd3
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitroupitroupitrou approved these changes

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner

@hugovkhugovkAwaiting requested review from hugovkhugovk is a code owner

@vsajipvsajipAwaiting requested review from vsajipvsajip is a code owner

@colesburycolesburyAwaiting requested review from colesbury

Assignees

No one assigned

Labels

skip newstopic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@corona10@pitrou@hugovk@itamaro@colesbury