Skip to content

gh-117031: Add support for new member types for PyMemberDef.type#117032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
serhiy-storchaka wants to merge 15 commits into
base:main
Choose a base branch
from
Draft

gh-117031: Add support for new member types for PyMemberDef.type #117032

serhiy-storchaka wants to merge 15 commits into from

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchakaserhiy-storchaka commented Mar 19, 2024•
edited by github-actions bot
Loading

Add support for standard C and Posix integer types like Py_T_UINT32, Py_T_PTRDIFF, Py_T_OFF and Py_T_PID.
Add Py_T_SSIZE as alias of Py_T_PYSSIZET.

📚 Documentation preview 📚: https://cpython-previews--117032.org.readthedocs.build/

@serhiy-storchaka
pythongh-117031: Add support for new member types for PyMemberDef.type
656ad30
Add support for standard C and Posix integer types like Py_T_UINT32, Py_T_PTRDIFF, Py_T_OFF and Py_T_PID. Add Py_T_SSIZE as alias of Py_T_PYSSIZET.
@bedevere-appbedevere-appbot mentioned this pull request Mar 19, 2024
Open
@serhiy-storchaka
Copy link
MemberAuthor

serhiy-storchaka commented Mar 27, 2024

!buildbot bsd

@bedevere-bot
Copy link

bedevere-bot commented Mar 27, 2024

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit cf4ce29 🤖

The command will test the builders whose names match following regular expression: bsd

The builders matched are:

  • AMD64 FreeBSD PR
  • AMD64 FreeBSD14 PR
  • AMD64 FreeBSD15 PR

@serhiy-storchaka
Copy link
MemberAuthor

serhiy-storchaka commented Mar 27, 2024

!buildbot s390

@bedevere-bot
Copy link

bedevere-bot commented Mar 27, 2024

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit cf4ce29 🤖

The command will test the builders whose names match following regular expression: s390

The builders matched are:

  • s390x Fedora Rawhide Clang Installed PR
  • s390x Fedora Rawhide Clang PR
  • s390x Fedora LTO PR
  • s390x Fedora Refleaks PR
  • s390x RHEL7 LTO + PGO PR
  • s390x Fedora LTO + PGO PR
  • s390x Fedora Clang PR
  • s390x Fedora PR
  • s390x Fedora Rawhide LTO PR
  • s390x Fedora Rawhide PR
  • s390x RHEL8 LTO PR
  • s390x Fedora Rawhide Refleaks PR
  • s390x Fedora Clang Installed PR
  • s390x RHEL8 PR
  • s390x Fedora Rawhide LTO + PGO PR
  • s390x RHEL8 Refleaks PR
  • s390x RHEL8 LTO + PGO PR
  • s390x RHEL7 PR
  • s390x RHEL7 LTO PR
  • s390x RHEL7 Refleaks PR
  • s390x SLES PR
  • s390x Debian PR

@vstinnervstinner mentioned this pull request Jun 12, 2024
Closed
vstinner
vstinner reviewed Apr 15, 2025
View reviewed changes
@vstinnervstinner mentioned this pull request Apr 15, 2025
Draft
vstinner
vstinner approved these changes Apr 15, 2025
View reviewed changes
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Modules/_testcapimodule.c
PyModule_AddObject(m, "SIZEOF_WCHAR_T", PyLong_FromSsize_t(sizeof(wchar_t)));
PyModule_AddObject(m, "SIZEOF_VOID_P", PyLong_FromSsize_t(sizeof(void*)));
PyModule_AddObject(m, "SIZEOF_TIME_T", PyLong_FromSsize_t(sizeof(time_t)));
PyModule_AddObject(m, "SIZEOF_INTMAX_T", PyLong_FromSsize_t(sizeof(intmax_t)));
Copy link
Member

@vstinnervstinnerApr 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's no longer used.

@encukou
Copy link
Member

encukou commented Apr 16, 2025

I prefer the #132550 approach -- solving this for all int types (not just C & POSIXy ones).

vstinner
vstinner reviewed Apr 17, 2025
View reviewed changes
Python/structmember.c
v=Py_NewRef(Py_None);
break;
casePy_T_INT8:
casePy_T_INT8|Py_T_UINT8:
Copy link
Member

@vstinnervstinnerApr 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this type? I don't understand the usage.

Copy link
MemberAuthor

@serhiy-storchakaserhiy-storchakaApr 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It accepts full range of Py_T_UINT8 plus negative values.

Copy link
Member

@vstinnervstinnerApr 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's weird. Which existing code needs such type?

@serhiy-storchakaserhiy-storchaka marked this pull request as draft May 4, 2025 14:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

@encukouencukouAwaiting requested review from encukou

@gpsheadgpsheadAwaiting requested review from gpsheadgpshead is a code owner

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

@hugovkhugovkAwaiting requested review from hugovkhugovk is a code owner

Assignees

No one assigned

Labels

topic-C-API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@serhiy-storchaka@bedevere-bot@encukou@vstinner