Skip to content

Conversation

@jaraco
Copy link
Member

@jaracojaraco commented Mar 20, 2024

@bedevere-appbedevere-appbot mentioned this pull request Mar 20, 2024
@jaracojaracoforce-pushed the gh-106531/refresh-importlib_resources-6.3.2 branch 2 times, most recently from 2e9212f to 98465e0CompareMarch 20, 2024 01:49
@jaracojaracoforce-pushed the gh-106531/refresh-importlib_resources-6.3.2 branch from 98465e0 to be08256CompareMarch 20, 2024 01:52
@jaraco
Copy link
MemberAuthor

Well shoot. I'd meant for this to land in Python 3.13, but lost track of it. @Yhg1s would you be willing to allow this to land in 3.13b2? It does add a deprecation for a usage that's likely rare.

@jaracojaraco requested a review from Yhg1sMay 28, 2024 12:57
@jaraco
Copy link
MemberAuthor

I was thinking about this overnight and I'm going to take the executive decision to merge it and back-port it, knowing that we might decide to delay the deprecation, especially if there's more than a small impact (which I don't expect).

@jaracojaraco added the needs backport to 3.13 bugs and security fixes label Jun 3, 2024
@jaraco
Copy link
MemberAuthor

On further consideration, after re-reading the summary in the blurb and looking at the diff, I'm reminded that this change is about much more than just the introduced deprecation. Still, I want to get this merged and we can discuss the viability of the backport in the backport PR.

@jaracojaraco enabled auto-merge (squash) June 3, 2024 15:05
@Yhg1s
Copy link
Member

Yhg1s commented Jun 4, 2024

Given that this is effectively syncing with a newer version of importlib_resources, I'm okay with this going into 3.13 at this point.

@miss-islington-app
Copy link

Thanks @jaraco for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 4, 2024
…GH-117054) Apply changes from importlib_resources 6.3.2. (cherry picked from commit 8d63c8d) Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
@bedevere-app
Copy link

GH-120014 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label Jun 4, 2024
jaraco added a commit that referenced this pull request Jun 4, 2024
…7054) (#120014) gh-106531: Apply changes from importlib_resources 6.3.2 (GH-117054) Apply changes from importlib_resources 6.3.2. (cherry picked from commit 8d63c8d) Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
@jaracojaraco deleted the gh-106531/refresh-importlib_resources-6.3.2 branch June 4, 2024 23:57
barneygale pushed a commit to barneygale/cpython that referenced this pull request Jun 5, 2024
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jaraco@Yhg1s