gh-117122: Fix pystats after incremental GC changes#117123
Uh oh!
There was an error while loading. Please reload this page.
Conversation
Uh oh!
There was an error while loading. Please reload this page.
| increment_size+=expand_region_transitively_reachable(&increment, gc, gcstate); | ||
| } | ||
| GC_STAT_ADD(1, objects_queued, region_size); | ||
| GC_STAT_ADD(1, objects_queued, increment_size); |
There was a problem hiding this comment.
I don't know if this is correct, but region_size doesn't exist.
There was a problem hiding this comment.
I'm not sure if this make sense anymore. Maybe just drop the "queued" stat?
markshannon left a comment
markshannon left a comment There was a problem hiding this comment.
This is going to conflict with #117120.
Once that's in, I'll review this properly.
| increment_size+=expand_region_transitively_reachable(&increment, gc, gcstate); | ||
| } | ||
| GC_STAT_ADD(1, objects_queued, region_size); | ||
| GC_STAT_ADD(1, objects_queued, increment_size); |
There was a problem hiding this comment.
I'm not sure if this make sense anymore. Maybe just drop the "queued" stat?
markshannon commented Mar 21, 2024
Actually, don't worry about the merge conflict. I can fix it in my PR |
mdboom commented Mar 21, 2024
I leave that to you, but this stat is new as of #116206 (it's just that it never compiled). |
2 participants
This fixes the pystats build after #116206.