gh-116622: Test updates for Android#117299
Uh oh!
There was an error while loading. Please reload this page.
Conversation
mhsmith requested review from brettcannon, ericsnowcurrently, gpshead, ncoghlan and warsaw as code owners
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| @unittest.skipIf( | ||
| sys.platform.startswith(("freebsd", "wasi")) | ||
| or(sys.platform=="android"andplatform.machine() =="x86_64"), | ||
| f"this platform doesn't implement IEE 754-2008 properly") | ||
| deftest_fma_zero_result(self): |
mhsmith commented Apr 4, 2024
@erlend-aasland: Are you able to review this PR? It's a continuation of the previous Android test updates from #115918. |
erlend-aasland left a comment
erlend-aasland left a comment There was a problem hiding this comment.
LGTM, with some nits. BTW, last time I checked, the sys.platform.startswith idiom was still recommended practice. I'd prefer if we could follow that.
Lib/test/test_os.py Outdated
| # The Android testbed redirects the native stdout to a pipe, | ||
| # which returns a different error code. | ||
| known_errnos.append(errno.EACCES) | ||
| if (sys.platform=="win32") or (e.errnoinknown_errnos): |
There was a problem hiding this comment.
The parentheses are not needed.
mhsmith commented Apr 5, 2024
Fixed.
I actually updated the |
erlend-aasland commented Apr 5, 2024
@mhsmith, thanks for the heads-up, I missed that docs update (and I've must have looked at the 3.12 docs). Perhaps we should consider backporting that doc patch. |
- re-enable test_fcntl_64_bit on Linux aarch64, but disable it on all Android ABIs - use support.setswitchinterval in all relevant tests - skip test_fma_zero_result on Android x86_64 - accept EACCES when calling os.get_terminal_size on Android
2 participants
This PR fixes various Android test issues which I've discovered over the last few weeks.