gh-116749: Run test suite with the GIL disabled#117437

colesbury · 2024-04-01T22:19:39Z

This is a combination of a few unmerged PRs to test running with the GIL disabled in the free-threaded build.

Issue: Disable GIL by default in free-threaded build #116749

colesbury · 2024-04-01T22:19:50Z

!buildbot nogil

bedevere-bot · 2024-04-01T22:19:53Z

🤖 New build scheduled with the buildbot fleet by @colesbury for commit 367ccf0 🤖

The command will test the builders whose names match following regular expression: nogil

The builders matched are:

x86-64 MacOS Intel ASAN NoGIL PR
AMD64 Windows Server 2022 NoGIL PR
AMD64 Ubuntu NoGIL Refleaks PR
AMD64 Ubuntu NoGIL PR
x86-64 MacOS Intel NoGIL PR
ARM64 MacOS M1 Refleaks NoGIL PR
ARM64 MacOS M1 NoGIL PR

colesbury · 2024-04-02T17:32:59Z

!buildbot nogil

bedevere-bot · 2024-04-02T17:33:02Z

🤖 New build scheduled with the buildbot fleet by @colesbury for commit dcfe6bc 🤖

The command will test the builders whose names match following regular expression: nogil

The builders matched are:

x86-64 MacOS Intel ASAN NoGIL PR
AMD64 Windows Server 2022 NoGIL PR
AMD64 Ubuntu NoGIL Refleaks PR
AMD64 Ubuntu NoGIL PR
x86-64 MacOS Intel NoGIL PR
ARM64 MacOS M1 Refleaks NoGIL PR
ARM64 MacOS M1 NoGIL PR

colesbury · 2024-04-02T19:19:01Z

!buildbot nogil

bedevere-bot · 2024-04-02T19:19:03Z

🤖 New build scheduled with the buildbot fleet by @colesbury for commit 0d1ed96 🤖

The command will test the builders whose names match following regular expression: nogil

The builders matched are:

x86-64 MacOS Intel ASAN NoGIL PR
AMD64 Windows Server 2022 NoGIL PR
AMD64 Ubuntu NoGIL Refleaks PR
AMD64 Ubuntu NoGIL PR
x86-64 MacOS Intel NoGIL PR
ARM64 MacOS M1 Refleaks NoGIL PR
ARM64 MacOS M1 NoGIL PR

colesbury · 2024-04-08T22:18:50Z

!buildbot nogil

bedevere-bot · 2024-04-08T22:18:53Z

🤖 New build scheduled with the buildbot fleet by @colesbury for commit 3d681c3 🤖

The command will test the builders whose names match following regular expression: nogil

The builders matched are:

x86-64 MacOS Intel NoGIL PR
ARM64 MacOS M1 NoGIL PR
AMD64 Windows Server 2022 NoGIL PR
AMD64 Ubuntu NoGIL PR
ARM64 MacOS M1 Refleaks NoGIL PR
x86-64 MacOS Intel ASAN NoGIL PR
AMD64 Ubuntu NoGIL Refleaks PR

colesbury · 2024-04-09T17:51:34Z

!buildbot nogil

bedevere-bot · 2024-04-09T17:51:37Z

🤖 New build scheduled with the buildbot fleet by @colesbury for commit b856049 🤖

The command will test the builders whose names match following regular expression: nogil

The builders matched are:

x86-64 MacOS Intel NoGIL PR
ARM64 MacOS M1 NoGIL PR
AMD64 Windows Server 2022 NoGIL PR
AMD64 Ubuntu NoGIL PR
ARM64 MacOS M1 Refleaks NoGIL PR
x86-64 MacOS Intel ASAN NoGIL PR
AMD64 Ubuntu NoGIL Refleaks PR

colesbury · 2024-04-09T18:04:47Z

!buildbot nogil

bedevere-bot · 2024-04-09T18:04:51Z

🤖 New build scheduled with the buildbot fleet by @colesbury for commit 29b7243 🤖

The command will test the builders whose names match following regular expression: nogil

The builders matched are:

x86-64 MacOS Intel NoGIL PR
ARM64 MacOS M1 NoGIL PR
AMD64 Windows Server 2022 NoGIL PR
AMD64 Ubuntu NoGIL PR
ARM64 MacOS M1 Refleaks NoGIL PR
x86-64 MacOS Intel ASAN NoGIL PR
AMD64 Ubuntu NoGIL Refleaks PR

colesbury · 2024-04-12T19:46:07Z

!buildbot nogil

bedevere-bot · 2024-04-12T19:46:10Z

🤖 New build scheduled with the buildbot fleet by @colesbury for commit 73c8d7c 🤖

The command will test the builders whose names match following regular expression: nogil

The builders matched are:

AMD64 Ubuntu NoGIL Refleaks PR
x86-64 MacOS Intel NoGIL PR
x86-64 MacOS Intel ASAN NoGIL PR
ARM64 MacOS M1 NoGIL PR
AMD64 Windows Server 2022 NoGIL PR
AMD64 Ubuntu NoGIL PR
ARM64 MacOS M1 Refleaks NoGIL PR

Fix issue where critical section isn't released Make _PyObject_TryGetInstanceAttribute return a bool

…issue w/ deleted dict

…y materialized dict Fix duplicate incref Fix comment Remove redundant if check on detach

…ting Deferred reference counting is not fully implemented yet. As a temporary measure, we immortalize objects that would use deferred reference counting to avoid multi-threaded scaling bottlenecks. This is only performed in the free-threaded build once the first non-main thread is started. Additionally, some tests, including refleak tests, suppress this behavior.

Disable GIL by default
2f299af

colesbury added DO-NOT-MERGE topic-free-threading labels Apr 1, 2024

bedevere-appbot mentioned this pull request Apr 1, 2024
Disable GIL by default in free-threaded build #116749
Closed

colesbury force-pushed the nogil-integration branch from dcfe6bc to 0d1ed96Compare April 2, 2024 18:51

colesbury added the skip news label Apr 2, 2024

colesbury force-pushed the nogil-integration branch 2 times, most recently from bf23f92 to ffa9641Compare April 8, 2024 18:43

pythongh-112075: Lock when inserting into shared keys
3d270d2

colesbury force-pushed the nogil-integration branch from 29b7243 to 73c8d7cCompare April 12, 2024 19:10

Fix return type
2e5797e

colesbury force-pushed the nogil-integration branch from 73c8d7c to df45b98Compare April 15, 2024 20:09

DinoV added 4 commits April 19, 2024 09:48

Make instance attributes stored in inline "dict" thread safe
79eb85c

Insert into dict on store if dict is materialized and other feedback
68fa243

_PyObject_TryStoreInstanceAttribute -> _PyObject_StoreInstanceAttribute
6d37f80
Fix issue where critical section isn't released Make _PyObject_TryGetInstanceAttribute return a bool

Cleanup _PyObject_SetManagedDict, use cst for inline valid flag, fix …
91e82d6
…issue w/ deleted dict

DinoVand others added 17 commits April 19, 2024 09:48

Refactor del/set into set_or_del_lock_held, and avoid locking on newl…
319f632
…y materialized dict Fix duplicate incref Fix comment Remove redundant if check on detach

tracing thread safety
2f6ca58

Lock on allocation, use version as sync point
fe19d59

Lock in non-debug builds
210b802

Move CHECK_EVAL_BREAKER in ENTER_EXECUTOR
597f40d

Don't potentially leak executor
8393bfe

Just use _Py_atomic_exchange_ptr instead of FT macro
65ff505

Use FT_ATOMIC_LOAD_UINTPTR_ACQUIRE for INSTRUMENTED_RESUME too
6e19601

Handle dict replacement case better
8860a7f

Decref materialized dict on fail to set
4b85255

Fix set_immortalize_deferred
0cab82c

Merge branch 'disable-gil-default' into nogil-integration
c716f32

Merge branch 'nogil_dict_pydictvalues' into nogil-integration
eb8ebe4

Merge branch 'nogil_settrace' into nogil-integration
74eec36

Merge branch 'pythongh-112075-lock-split-keys' into nogil-integration
a825875

Merge branch 'pythongh-117783-immortalize' into nogil-integration
539595a

colesbury force-pushed the nogil-integration branch from df45b98 to 539595aCompare April 19, 2024 20:25

colesbury closed this Apr 26, 2024

Uh oh!

gh-116749: Run test suite with the GIL disabled#117437

gh-116749: Run test suite with the GIL disabled #117437

Uh oh!

Conversation

colesbury commented Apr 1, 2024• edited by bedevere-app botLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

colesbury commented Apr 1, 2024

Uh oh!

bedevere-bot commented Apr 1, 2024

Uh oh!

colesbury commented Apr 2, 2024

Uh oh!

bedevere-bot commented Apr 2, 2024

Uh oh!

colesbury commented Apr 2, 2024

Uh oh!

bedevere-bot commented Apr 2, 2024

Uh oh!

colesbury commented Apr 8, 2024

Uh oh!

bedevere-bot commented Apr 8, 2024

Uh oh!

colesbury commented Apr 9, 2024

Uh oh!

bedevere-bot commented Apr 9, 2024

Uh oh!

colesbury commented Apr 9, 2024

Uh oh!

bedevere-bot commented Apr 9, 2024

Uh oh!

colesbury commented Apr 12, 2024

Uh oh!

bedevere-bot commented Apr 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

colesbury commented Apr 1, 2024•
edited by bedevere-app bot
Loading