gh-109802: Add coverage test for complex_abs()#117449
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This tests overflow on L594. // line numbers wrt to 0f2fa61
This comment was marked as outdated.
This comment was marked as outdated.
encukou approved these changes Apr 4, 2024
Uh oh!
There was an error while loading. Please reload this page.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
* pythongh-109802: Add coverage test for complex_abs() This tests overflow on L594. // line numbers wrt to 0f2fa61
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tests overflow on L594.
// line numbers wrt to 0f2fa61
N.B. This factor out last test from #109642. Actually this tested in test_cmath.py, but I think it worth to keep complexobject.c tests in test_complex.py and test_capi/test_complex.py.