Skip to content

Conversation

@vstinner
Copy link
Member

@vstinnervstinner commented Apr 2, 2024

Add libclinic.lang_c module and move the following classes and functions there:

  • CLanguage
  • declare_parser()

Add libclinic.codegen and move the following classes there:

  • BlockPrinter
  • BufferSeries
  • Destination

Move these functions to libclinic.function:

  • permute_left_option_groups()
  • permute_optional_groups()
  • permute_right_option_groups()

@vstinnervstinnerforce-pushed the ac_clang branch 2 times, most recently from 21917ec to 04d91d6CompareApril 2, 2024 12:33
@vstinner
Copy link
MemberAuthor

@erlend-aasland: I updated the PR to address your review. Please review the updated PR.

I used git rebase to rewrite the commit message and rename files.

Copy link
Contributor

@erlend-aaslanderlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think libclinic.codegen makes sense. Also, it makes sense to put the option group stuff together with the parameter stuff (currently in function.py).

I realise that we already got a libclinic.language.py file with the PythonLanguage and Language classes. I'm fine with using clanguage.py instead of lang_c.py, as was your original suggestion. Up to you.

Add libclinic.clanguage module and move the following classes and functions there: * CLanguage * declare_parser() Add libclinic.codegen and move the following classes there: * BlockPrinter * BufferSeries * Destination Move the following functions to libclinic.function: * permute_left_option_groups() * permute_optional_groups() * permute_right_option_groups()
@vstinner
Copy link
MemberAuthor

I realise that we already got a libclinic.language.py file with the PythonLanguage and Language classes. I'm fine with using clanguage.py instead of lang_c.py, as was your original suggestion. Up to you.

I renamed the file to clanguage.py.

@vstinnervstinner enabled auto-merge (squash) April 3, 2024 17:47
@vstinnervstinner merged commit c43f6a4 into python:mainApr 3, 2024
@vstinnervstinner deleted the ac_clang branch April 3, 2024 18:17
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
) Add libclinic.clanguage module and move the following classes and functions there: * CLanguage * declare_parser() Add libclinic.codegen and move the following classes there: * BlockPrinter * BufferSeries * Destination Move the following functions to libclinic.function: * permute_left_option_groups() * permute_optional_groups() * permute_right_option_groups()
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner@erlend-aasland