GH-117546: Fix symlink resolution in os.path.realpath('loop/../link')#117568
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…/link')` Continue resolving symlink targets after encountering a symlink loop, which matches coreutils `realpath` behaviour.
serhiy-storchaka approved these changes Apr 9, 2024
Member
serhiy-storchaka left a comment
serhiy-storchaka left a comment There was a problem hiding this comment.
LGTM.
#117562 includes a similar change.
ContributorAuthor
barneygale commented Apr 10, 2024
Thank you for the review |
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
…/link')` (python#117568) Continue resolving symlink targets after encountering a symlink loop, which matches coreutils `realpath` behaviour.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continue resolving symlink targets after encountering a symlink loop, which matches coreutils
realpathbehaviour. POSIX-only fix; Windows works differently.os.path.realpath('loop/../link')does not resolve link #117546📚 Documentation preview 📚: https://cpython-previews--117568.org.readthedocs.build/