gh-76785: Add More Tests to test_interpreters.test_api#117662
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ericsnowcurrently requested review from gvanrossum and markshannon as code owners
ericsnowcurrently added the 🔨 test-with-buildbots 
bedevere-bot commented Apr 10, 2024
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 9db5a2b 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot removed the 🔨 test-with-buildbots bedevere-bot commented Apr 11, 2024
|
Comment on lines +1417 to +1422
| withself.subTest('main'): | ||
| expected=_interpreters.new_config('legacy') | ||
| expected.gil='own' | ||
| interpid, *_=_interpreters.get_main() | ||
| config=_interpreters.get_config(interpid) | ||
| self.assert_ns_equal(config, expected) |
Contributor
There was a problem hiding this comment.
FYI, this is a duplicate of the above subtest
MemberAuthor
There was a problem hiding this comment.
Looks like this is addressed in gh-117651. I'm fine with fixing it there since it's already done. 😄
ericsnowcurrently added a commit that referenced this pull request Apr 16, 2024
gh-117662 introduced some refleaks, or, rather, exposed some existing refleaks. The leaks are coming when test.support.os_helper is imported in a "legacy" interpreter. I've updated test.test_interpreters.utils to avoid importing os_helper, which fixes the leaks. I'll address the root cause separately.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
…h-117662) In addition to the increase test coverage, this is a precursor to sorting out how we handle interpreters created directly via the C-API.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
…7913) pythongh-117662 introduced some refleaks, or, rather, exposed some existing refleaks. The leaks are coming when test.support.os_helper is imported in a "legacy" interpreter. I've updated test.test_interpreters.utils to avoid importing os_helper, which fixes the leaks. I'll address the root cause separately.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a precursor to sorting out how we handle interpreters created directly via the C-API.