Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 33.9k
gh-117655: Fix test_strptime raises a DeprecationWarning#117668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
nineteendo commented Apr 9, 2024 • edited by bedevere-app bot
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by bedevere-app bot
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as outdated.
This comment was marked as outdated.
erlend-aasland commented Apr 18, 2024
I'm not the correct person to review this. I'll request Greg's review, since he authored the recent change that introduced this deprecation warning. |
erlend-aasland commented Apr 18, 2024
Please give Greg (and Paul) reasonable time to review before eventually pinging them. Quoting the devguide:
|
nineteendo commented Apr 18, 2024
OK. |
Uh oh!
There was an error while loading. Please reload this page.
nineteendo commented May 11, 2024 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Thanks. I'll ask on Discourse for someone else to review this as well. |
nineteendo commented May 11, 2024
Thanks, I didn't dare pinging you after the comment of Erlend. |
gpshead commented May 11, 2024
no problem, i'm always overflowing with notifications so I easily miss things or have other priorities at times. thanks for the cleanup! I probably should've done this type of thing when making the original change. thanks for the pings! |
Thanks @nineteendo for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
…rning (pythonGH-117668) * Fix `test_strptime` raises a DeprecationWarning * Ignore deprecation warnings where appropriate. * Update Lib/test/datetimetester.py This is follow on work to silence unnecessary warnings from the test suite that changes for python#70647 added. (cherry picked from commit abead54) Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
GH-118956 is a backport of this pull request to the 3.13 branch. |
…arning (GH-117668) (GH-118956) gh-117655: Prevent `test_strptime` from raising a DeprecationWarning (GH-117668) * Fix `test_strptime` raises a DeprecationWarning * Ignore deprecation warnings where appropriate. * Update Lib/test/datetimetester.py This is follow on work to silence unnecessary warnings from the test suite that changes for #70647 added. (cherry picked from commit abead54) Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
bedevere-bot commented May 12, 2024
|
bedevere-bot commented May 12, 2024
|
…rning (pythonGH-117668) * Fix `test_strptime` raises a DeprecationWarning * Ignore deprecation warnings where appropriate. * Update Lib/test/datetimetester.py This is follow on work to silence unnecessary warnings from the test suite that changes for python#70647 added.
test_strptimeraises a DeprecationWarning #117655