Skip to content

Conversation

@methane
Copy link
Member

@methanemethane commented Apr 12, 2024

Copy link
Contributor

@hauntsaninjahauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Maybe document the change https://docs.python.org/dev/whatsnew/3.13.html#improved-modules for more visibility.

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@methanemethane merged commit 6dc661b into python:mainApr 16, 2024
@methanemethane deleted the utf8-pth-file branch April 16, 2024 03:56
@bedevere-app
Copy link

GH-117917 is a backport of this pull request to the 3.12 branch.

methane added a commit to methane/cpython that referenced this pull request Apr 16, 2024
…g when reading .pth file (pythonGH-117802) (cherry picked from commit 6dc661b) Co-authored-by: Inada Naoki <songofacandy@gmail.com>
@bedevere-app
Copy link

GH-117918 is a backport of this pull request to the 3.11 branch.

@bedevere-app
Copy link

GH-117917 is a backport of this pull request to the 3.12 branch.

@bedevere-app
Copy link

GH-117918 is a backport of this pull request to the 3.11 branch.

methane added a commit that referenced this pull request Apr 16, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@methane@vstinner@hauntsaninja