Skip to content

gh-112075: Lock when inserting into shared keys#117824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
colesbury wants to merge 2 commits into from
Closed

gh-112075: Lock when inserting into shared keys #117824

colesbury wants to merge 2 commits into from

Conversation

@colesbury
Copy link
Contributor

@colesburycolesbury commented Apr 12, 2024•
edited by bedevere-app bot
Loading

This is a draft PR similar to #117528, but:

  1. Separates out the handling of split keys
  2. Doesn't yet handle the necessary locking in _Py_dict_lookup for things like the PyDict_GetItemRef locking fallback.

@bedevere-appbedevere-appbot mentioned this pull request Apr 12, 2024
Closed
@colesburycolesbury mentioned this pull request Apr 12, 2024
Closed
@colesbury
Copy link
ContributorAuthor

colesbury commented Apr 26, 2024

Addressed in #117528

@colesburycolesbury deleted the gh-112075-lock-split-keys branch July 16, 2024 19:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methanemethaneAwaiting requested review from methanemethane will be requested when the pull request is marked ready for reviewmethane is a code owner

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon will be requested when the pull request is marked ready for reviewmarkshannon is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@colesbury