Skip to content

gh-116935: Document that heap types need to support garbage collection#118021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
encukou merged 8 commits into from
Apr 19, 2024
Merged

gh-116935: Document that heap types need to support garbage collection #118021

encukou merged 8 commits into from
Apr 19, 2024

Conversation

@savannahostrowski
Copy link
Member

@savannahostrowskisavannahostrowski commented Apr 18, 2024•
edited by encukou
Loading

@bedevere-appbedevere-appbot mentioned this pull request Apr 18, 2024
Closed
@bedevere-appbedevere-appbot added docs Documentation in the Doc dir skip news awaiting review labels Apr 18, 2024
@encukou
Copy link
Member

encukou commented Apr 18, 2024

Thank you for the addition!
Could you please add a link to Supporting Cyclic Garbage Collection, so readers can learn about the details if they don't already know them?

@savannahostrowskisavannahostrowski mentioned this pull request Apr 19, 2024
Merged
savannahostrowski
savannahostrowski commented Apr 19, 2024
View reviewed changes
JelleZijlstra
JelleZijlstra approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@JelleZijlstraJelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wording looks good but I'd like another review from someone who is more familiar with the C API.

kalebers
kalebers approved these changes Apr 19, 2024
View reviewed changes
Copy link

@kaleberskalebers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, thanks for adding helpful information!

encukou
encukou reviewed Apr 19, 2024
View reviewed changes
@encukouencukou enabled auto-merge (squash) April 19, 2024 09:01
@encukouencukou added the needs backport to 3.12 only security fixes label Apr 19, 2024
@encukouencukou merged commit 5d54436 into python:mainApr 19, 2024
@miss-islington-app
Copy link

miss-islington-appbot commented Apr 19, 2024

Thanks @savannahostrowski for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 19, 2024
@savannahostrowski@miss-islington
pythongh-116935: Document that heap types need to support garbage col…
286137a
…lection (pythonGH-118021) (cherry picked from commit 5d54436) Co-authored-by: Savannah Ostrowski <[email protected]>
@bedevere-app
Copy link

bedevere-appbot commented Apr 19, 2024

GH-118092 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12 only security fixes label Apr 19, 2024
encukou pushed a commit that referenced this pull request Apr 19, 2024
@miss-islington@savannahostrowski
[3.12]gh-116935: Document that heap types need to support garbage co…
f278b8f
…llection (GH-118021) (GH-118092) gh-116935: Document that heap types need to support garbage collection (GH-118021) (cherry picked from commit 5d54436) Co-authored-by: Savannah Ostrowski <[email protected]>
@savannahostrowski
Copy link
MemberAuthor

savannahostrowski commented Apr 19, 2024

Thanks for the reviews, folks!

@savannahostrowskisavannahostrowski deleted the fix-116935 branch September 27, 2024 16:55
@neoneneneonene mentioned this pull request Sep 17, 2025
Merged
7 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukouencukouencukou approved these changes

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes

+1 more reviewer

@kaleberskaleberskalebers approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

docs(easy): Document that heap types need to support garbage collection

4 participants

@savannahostrowski@encukou@JelleZijlstra@kalebers