Skip to content

gh-118023: Fix reference leak#118025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iritkatriel merged 1 commit into from
Apr 18, 2024
Merged

gh-118023: Fix reference leak #118025

iritkatriel merged 1 commit into from
Apr 18, 2024

Conversation

@Eclips4
Copy link
Member

@Eclips4Eclips4 commented Apr 18, 2024•
edited by bedevere-app bot
Loading

@bedevere-appbedevere-appbot mentioned this pull request Apr 18, 2024
Closed
@Eclips4
Copy link
MemberAuthor

Eclips4 commented Apr 18, 2024

Before this PR:

./python.exe-mtest-R3:3test_compileUsingrandomseed: 1149496220:00:00loadavg: 4.27Run1testsequentially0:00:00loadavg: 4.27 [1/1] test_compilebeginning6repetitions. Showingnumberofleaks (. for0orless, Xfor10ormore) 123:456XX4444test_compileleaked [2, 2, 2] references, sum=6test_compileleaked [4, 4, 4] memoryblocks, sum=12test_compilefailed (referenceleak) ==Testsresult: FAILURE==1testfailed: test_compileTotalduration: 12.2secTotaltests: run=164skipped=1Totaltestfiles: run=1/1failed=1Result: FAILURE

After this PR:

./python.exe-mtest-R3:3test_compileUsingrandomseed: 10100926190:00:00loadavg: 3.37Run1testsequentially0:00:00loadavg: 3.37 [1/1] test_compilebeginning6repetitions. Showingnumberofleaks (. for0orless, Xfor10ormore) 123:456XX. ... ==Testsresult: SUCCESS==1testOK. Totalduration: 12.3secTotaltests: run=164skipped=1Totaltestfiles: run=1/1Result: SUCCESS

iritkatriel
iritkatriel approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@iritkatrieliritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@iritkatrieliritkatriel enabled auto-merge (squash) April 18, 2024 07:09
@iritkatrieliritkatriel merged commit cd7cf15 into python:mainApr 18, 2024
@Eclips4Eclips4 deleted the issue-118023 branch April 18, 2024 07:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatrieliritkatrieliritkatriel approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Eclips4@iritkatriel