GH-116202: Incorporate invalidation check into _START_EXECUTOR.#118044
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The uop pair stats show that
_START_EXECUTOR_CHECK_VALIDITYis the second most common pair and that every_START_EXECUTORis followed by either a_CHECK_VALIDITYor_CHECK_VALIDITY_SET_IP.This PR adds a validity check to
_START_EXECUTORallowing the optimizer to remove the redundant_CHECK_VALIDITYs.This also reduces the number of validity checks in loops as traces are known to be valid at
_JUMP_TO_TOP.becomes: