GH-115419: Improve list of escaping functions#118054
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
32 tasks
gvanrossum approved these changes Apr 18, 2024
Comment on lines 360 to +361
| "Py_DECREF", | ||
| "Py_XDECREF", |
Member
There was a problem hiding this comment.
It would seem technically wrong to treat decref as non-escaping, but I understand it's expedient and also 99.999% correct. Or am I missing something?
MemberAuthor
There was a problem hiding this comment.
That's correct. We already have Py_DECREF on this list, so adding Py_XDECREF is consistent.
MemberAuthor
markshannon commented Apr 19, 2024
The failures on emulated ARM are a known issue. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve list of C functions that are considered to escape, given more accurate metadata.
The following uops are no longer considered to escape:
_STORE_SUBSCR_LIST_INT_POP_FRAME_MAKE_CELL_STORE_ATTR_SLOT_COMPARE_OP_FLOAT_INIT_CALL_PY_EXACT_ARGSThe following uop is now considered correctly to escape:
_CALL_BUILTIN_CLASSNote that, although
_PUSH_FRAMEdoesn't escape, it does need a prior_SET_IPfor the return address.This PR also makes sure that
_PUSH_FRAMEgets a valid instruction pointer.