GH-115419: Move setting the instruction pointer to error exit stubs#118088
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, in tier 2, we emit a
_SET_IPbefore any instruction that may error so that the instruction pointer is correctly set.Since errors are relatively rare, this is wasteful.
With this PR, the error handling uop
_ERROR_POP_Nsets the instruction pointer, so we don't need to emit the_SET_IPinline.We still need to emit
_SET_IPbefore instructions that escape.