gh-117953: Add Internal struct _Py_ext_module_loader_info#118194
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ericsnowcurrentlyforce-pushed the add-loader-info-struct branch from d2d8b88 to 2a9b621Compareericsnowcurrently requested review from brettcannon, kumaraditya303, ncoghlan and warsaw as code ownersericsnowcurrently removed request for brettcannon, kumaraditya303, ncoghlan and warsawMemberAuthor
ericsnowcurrently commented Apr 24, 2024
Looks like a refleak slipped through with this PR. I'm working on a fix. |
ericsnowcurrently added a commit that referenced this pull request Apr 24, 2024
ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this pull request Apr 24, 2024
…-118250) A couple of refleaks slipped through in pythongh-118194. This takes care of them. (AKA _Py_ext_module_loader_info_init() does not steal references.)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've pulled this out of #118116.
This helps with a later change that splits up
_PyImport_LoadDynamicModuleWithSpec().