Skip to content

Conversation

@ncoghlan
Copy link
Contributor

@ncoghlanncoghlan commented Apr 25, 2024

Proposed documentation wording taken from the
withdrawn PEP 558 (which had switched to the
Python level semantics proposed in PEP 667 prior
to its withdrawal).


📚 Documentation preview 📚: https://cpython-previews--118265.org.readthedocs.build/

Proposed documentation wording taken from the withdrawn PEP 558 (which had switched to the Python level semantics proposed in PEP 667 prior to its withdrawal).
@ncoghlan
Copy link
ContributorAuthor

DO-NOT-MERGE label added, as this should only be merged after the PEP 667 implementation in #115153 has been completed and merged.

@ncoghlanncoghlan changed the title locals() documentation update for PEP 667gh-74929: locals() documentation update for PEP 667Apr 26, 2024
@nineteendo
Copy link
Contributor

Wouldn't it better to convert the pull request back to a draft? GitHub automatically prevents you from merging those.

@ncoghlanncoghlan self-assigned this Apr 28, 2024
@ncoghlanncoghlan marked this pull request as draft April 28, 2024 10:04
@ncoghlan
Copy link
ContributorAuthor

Wouldn't it better to convert the pull request back to a draft? GitHub automatically prevents you from merging those.

Good point, done (enough years of experience where draft PRs weren't available that I still forget to use them when appropriate)

implicitly refreshed by other operations, such as calling ``locals()``
again. Obtaining the legacy CPython behaviour now requires explicit
calls to update the initially returned dictionary with the results
of subsequent calls to ``locals()``.
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I plan to eventually replace the latter two sentences here with something like "For details, refer to the 'Python 3.13 porting guide'" (with a link to the relevant part of the 3.13 What's New document). That will be in a later PR that adds an initial version of the What's New update for PEP 667, though.

@ncoghlanncoghlan marked this pull request as ready for review May 6, 2024 10:04
@ncoghlanncoghlan merged commit 757fd3e into python:mainMay 6, 2024
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
) Documentation wording taken from the withdrawn PEP 558 (which had switched to the Python level semantics proposed in PEP 667 prior to its withdrawal).
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ncoghlan@nineteendo