Skip to content

gh-117225: Move colorize functionality to own internal module#118283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hugovk merged 5 commits into from
May 1, 2024
Merged

gh-117225: Move colorize functionality to own internal module #118283

hugovk merged 5 commits into from
May 1, 2024

Conversation

@hugovk
Copy link
Member

@hugovkhugovk commented Apr 25, 2024•
edited by bedevere-app bot
Loading

Here's the refactoring postponed from PR #117583.

@bedevere-appbedevere-appbot mentioned this pull request Apr 25, 2024
Closed
@hugovkhugovk mentioned this pull request Apr 25, 2024
Merged
Privat33r-dev
Privat33r-dev reviewed Apr 25, 2024
View reviewed changes
nineteendo
nineteendo reviewed Apr 25, 2024
View reviewed changes
Copy link
Contributor

@nineteendonineteendo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these newlines.

@hugovkhugovk marked this pull request as draft April 26, 2024 07:31
@hugovkhugovk mentioned this pull request Apr 26, 2024
Closed
@mpagempage mentioned this pull request Apr 26, 2024
Merged
@colesburycolesbury mentioned this pull request Apr 26, 2024
Closed
Privat33r-dev
Privat33r-dev reviewed Apr 28, 2024
View reviewed changes
@hugovkhugovk marked this pull request as ready for review April 29, 2024 21:37
@hugovk
Copy link
MemberAuthor

hugovk commented Apr 29, 2024

Somehow managed to find two free-threaded bugs with this PR, but they're fixed now.

@hugovkhugovk merged commit 3b3f8de into python:mainMay 1, 2024
@hugovkhugovk deleted the doctest-refactor-colorize branch May 1, 2024 18:27
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
@hugovk@SonicField
pythongh-117225: Move colorize functionality to own internal module (p…
1e0a640
…ython#118283)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatrieliritkatrielAwaiting requested review from iritkatriel

2 more reviewers

@Privat33r-devPrivat33r-devPrivat33r-dev left review comments

@nineteendonineteendonineteendo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hugovk@Privat33r-dev@nineteendo