Skip to content

gh-116749: Disable GIL by default in free-threaded build#118295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
colesbury merged 2 commits into from
Apr 26, 2024
Merged

gh-116749: Disable GIL by default in free-threaded build #118295

colesbury merged 2 commits into from
Apr 26, 2024

Conversation

@colesbury
Copy link
Contributor

@colesburycolesbury commented Apr 25, 2024•
edited by bedevere-app bot
Loading

Switch GIL to disabled by default in free-threaded build so that the free-threaded CIs catch thread-safety issues.

@colesbury
pythongh-116749: Disable GIL by default in free-threaded build
9fc88f4
Switch GIL to disabled by default in free-threaded build so that the free-threaded CIs catch thread-safety issues.
@colesbury
Copy link
ContributorAuthor

colesbury commented Apr 25, 2024

!buildbot nogil

@bedevere-appbedevere-appbot mentioned this pull request Apr 25, 2024
Closed
@bedevere-bot
Copy link

bedevere-bot commented Apr 25, 2024

🤖 New build scheduled with the buildbot fleet by @colesbury for commit 9fc88f4 🤖

The command will test the builders whose names match following regular expression: nogil

The builders matched are:

  • x86-64 MacOS Intel ASAN NoGIL PR
  • AMD64 Ubuntu NoGIL Refleaks PR
  • ARM64 MacOS M1 NoGIL PR
  • AMD64 Windows Server 2022 NoGIL PR
  • AMD64 Ubuntu NoGIL PR
  • ARM64 MacOS M1 Refleaks NoGIL PR
  • x86-64 MacOS Intel NoGIL PR

@colesburycolesbury requested review from DinoV and swtaarrsApril 26, 2024 15:04
@colesburycolesbury marked this pull request as ready for review April 26, 2024 15:04
SonicField
SonicField approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@SonicFieldSonicField left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

swtaarrs
swtaarrs reviewed Apr 26, 2024
View reviewed changes
DinoV
DinoV approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@DinoVDinoV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!!

swtaarrs
swtaarrs approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@swtaarrsswtaarrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting 😃

@colesburycolesbury merged commit 5a90de0 into python:mainApr 26, 2024
@colesburycolesbury deleted the gh-116749-disable-gil branch April 26, 2024 18:22
@colesburycolesbury mentioned this pull request Apr 26, 2024
Closed
@corona10
Copy link
Member

corona10 commented Apr 26, 2024

Historical moment!

@cychen2021
Copy link

cychen2021 commented Apr 27, 2024

Cool!

@swtaarrsswtaarrs mentioned this pull request Apr 30, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swtaarrsswtaarrsswtaarrs approved these changes

@DinoVDinoVDinoV approved these changes

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

+1 more reviewer

@SonicFieldSonicFieldSonicField approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip newstopic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@colesbury@bedevere-bot@corona10@cychen2021@swtaarrs@DinoV@SonicField