Skip to content

Conversation

@abhinav-upadhyay
Copy link
Contributor

@abhinav-upadhyayabhinav-upadhyay commented May 5, 2024

@ghost
Copy link

ghost commented May 5, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-appbedevere-appbot added the tests Tests in the Lib/test dir label May 5, 2024
@bedevere-app
Copy link

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@Eclips4
Copy link
Member

Hello!
Sorry, but CPython as a rule does not accept cosmetic PRs.
I'm going to close this one.

@Eclips4Eclips4 closed this May 5, 2024
@abhinav-upadhyay
Copy link
ContributorAuthor

Okay, no issues!

However, I would just add that having the wrong variable name in that place and fixing its name to reflect the correct intention of its use is not as cosmetic as fixing a typo in the name. The person reading that is going to be left confused.

I'm not sure who the author of that module is but I'm pretty sure they would fix it themselves if they noticed it.

@pablogsalpablogsal reopened this May 7, 2024
@bedevere-app
Copy link

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@pablogsal
Copy link
Member

I'm reopening this as even if this is changing just a variable name this is a bit of a "bug" as the variable name its actually misleading (as it doesn't contain what it says it contains).

@pablogsalpablogsal changed the title Use the right variable name based on the field we are trying readbpo-115773: Use the right variable name based on the field we are trying readMay 7, 2024
@pablogsalpablogsal enabled auto-merge (squash) May 7, 2024 13:45
@pablogsalpablogsal changed the title bpo-115773: Use the right variable name based on the field we are trying readgh-115773: Use the right variable name based on the field we are trying readMay 7, 2024
@pablogsalpablogsal merged commit 26bab42 into python:mainMay 7, 2024
@abhinav-upadhyayabhinav-upadhyay deleted the fix-variable-name branch May 8, 2024 05:52
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@abhinav-upadhyay@Eclips4@pablogsal