gh-117398: Move types to datetime state#118606
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MemberAuthor
vstinner commented May 7, 2024
I marked the PR as a draft until the main branch becomes Python 3.14. |
MemberAuthor
vstinner commented May 8, 2024
The main branch is now Python 3.14. I mark the PR as ready for review. @erlend-aasland@corona10: Do you want to review it? |
Move types to the datetime_state structure of the _datetime extension.
erlend-aasland approved these changes May 10, 2024
Contributor
erlend-aasland left a comment
erlend-aasland left a comment There was a problem hiding this comment.
Makes sense as a first step!
ericsnowcurrently pushed a commit to ericsnowcurrently/cpython that referenced this pull request May 28, 2024
Move types to the datetime_state structure of the _datetime extension.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move types to the datetime_state structure of the _datetime extension.