gh-118507 : Refactor nt._path_is*

[nineteendo]

• Issue: Refactor nt._path_is* & nt._path_[l]exists #118507

[nineteendo]

@zooba, I added the test Eryk requested.

[erlend-aasland]

You already have two extremely competent reviewers for this PR: Eryk and Steve. Why are you keeping pinging other core devs? This only creates unneeded noise; please stop it.

[nineteendo]

OK, but I'm not sure what Steve is waiting for. I thought we were done here. Could you react with eyes if you saw this?
I don't want to wait till June 8th before pinging the issue and another week before I can ask on Discourse.

[zooba]

Mostly I was waiting for enough free time to give it a proper review - while I get work time to work on Python, it's not strictly my job, so I can't always prioritise reviews over other things.

This looks good now. Since we need an additional change for 3.12, we'll need a manual backport for that

[miss-islington-app]

Thanks @nineteendo for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

[miss-islington-app]

Sorry, @nineteendo and @zooba, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker b64182550f73e556344bd754d32e3be5d22a74e1 3.12 

[bedevere-app]

GH-119360 is a backport of this pull request to the 3.13 branch.

[bedevere-app]

GH-119381 is a backport of this pull request to the 3.12 branch.

[bedevere-app]

GH-119381 is a backport of this pull request to the 3.12 branch.

[nineteendo]

Note that it's not a full backport, as the C implementation of ntpath.isjunction() & ntpath.lexists() isn't included yet to minimise the risk of changed behaviour. We can consider backporting them later once we're more confident.

[bedevere-app]

GH-119420 is a backport of this pull request to the 3.12 branch.

[bedevere-app]

GH-119420 is a backport of this pull request to the 3.12 branch.

[socal-nerdtastic]

Do you guys realize this breaks using path as a kwarg? You may want to update the docs.

os.path.exists(path=".") TypeError: nt._path_exists() takes no keyword arguments 

[nineteendo]

@zooba, should this be fixed?

diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c index f02b6d1779827f..2a65752d9431fe 100644 --- a/Modules/posixmodule.c+++ b/Modules/posixmodule.c@@ -5385,7 +5385,6 @@ _testFileType(path_t *path, int testedType) os._path_exists -> bool path: path_t(allow_fd=True, suppress_value_error=True) - / Test whether a path exists. Returns False for broken symbolic links. @@ -5403,7 +5402,6 @@ os__path_exists_impl(PyObject *module, path_t *path) os._path_lexists -> bool path: path_t(allow_fd=True, suppress_value_error=True) - / Test whether a path exists. Returns True for broken symbolic links.

[nineteendo]

@sobolevn is this a problem?