Skip to content

Docs: fix typos in documentation#118815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vsajip merged 1 commit into from
May 10, 2024
Merged

Docs: fix typos in documentation #118815

vsajip merged 1 commit into from
May 10, 2024

Conversation

@xyb
Copy link
Contributor

@xybxyb commented May 9, 2024•
edited by github-actions bot
Loading

@bedevere-appbedevere-appbot added docs Documentation in the Doc dir skip news awaiting review labels May 9, 2024
vsajip
vsajip requested changes May 9, 2024
View reviewed changes
Copy link
Member

@vsajipvsajip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other changes look fine to me.

@bedevere-app
Copy link

bedevere-appbot commented May 9, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Privat33r-dev
Privat33r-dev suggested changes May 9, 2024
View reviewed changes
Copy link
Contributor

@Privat33r-devPrivat33r-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, revert the latin changes as suggested. Other changes are good, thank you for your contribution.

@xyb
Copy link
ContributorAuthor

xyb commented May 10, 2024

@vsajip@Privat33r-dev Thank you for your advices. I have made the requested changes; please review again.

@bedevere-app
Copy link

bedevere-appbot commented May 10, 2024

Thanks for making the requested changes!

@vsajip: please review the changes made to this pull request.

@bedevere-appbedevere-appbot requested a review from vsajipMay 10, 2024 03:34
@vsajipvsajip merged commit 17a2cc1 into python:mainMay 10, 2024
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 10, 2024
@xyb@SonicField
Docs: fix typos in documentation (pythonGH-118815)
6502eb3
@xybxyb deleted the fixtypos branch May 10, 2024 10:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsajipvsajipvsajip approved these changes

@brettcannonbrettcannonAwaiting requested review from brettcannonbrettcannon is a code owner

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan is a code owner

@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

+1 more reviewer

@Privat33r-devPrivat33r-devPrivat33r-dev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip issueskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xyb@vsajip@Privat33r-dev@Eclips4