Skip to content

gh-118817: Fix asyncio REPL on Windows#118819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gvanrossum merged 3 commits into from
May 9, 2024
Merged

gh-118817: Fix asyncio REPL on Windows #118819

gvanrossum merged 3 commits into from
May 9, 2024
+8 −4

Conversation

@Eclips4
Copy link
Member

@Eclips4Eclips4 commented May 9, 2024•
edited by bedevere-app bot
Loading

@bedevere-appbedevere-appbot mentioned this pull request May 9, 2024
Closed
Eclips4
Eclips4 commented May 9, 2024
View reviewed changes
@Eclips4Eclips4 added 3.13 bugs and security fixes needs backport to 3.13 bugs and security fixes and removed 3.13 bugs and security fixes labels May 9, 2024
sobolevn
sobolevn approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@sobolevnsobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough for me!

CC @ambv

gvanrossum
gvanrossum approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@gvanrossumgvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@gvanrossumgvanrossum merged commit c3643a1 into python:mainMay 9, 2024
@miss-islington-app
Copy link

miss-islington-appbot commented May 9, 2024

Thanks @Eclips4 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@Eclips4Eclips4 deleted the fix-asyncio-repl branch May 9, 2024 15:20
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 9, 2024
@Eclips4@miss-islington
pythongh-118817: Fixasyncio REPLon Windows (pythonGH-118819)
89cc421
(cherry picked from commit c3643a1) Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
@bedevere-app
Copy link

bedevere-appbot commented May 9, 2024

GH-118847 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label May 9, 2024
gvanrossum pushed a commit that referenced this pull request May 9, 2024
@miss-islington@Eclips4
[3.13]gh-118817: Fixasyncio REPLon Windows (GH-118819) (#118847)
738877a
(cherry picked from commit c3643a1) Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 10, 2024
@Eclips4@SonicField
pythongh-118817: Fixasyncio REPLon Windows (python#118819)
ec921f7
@ambvambv added the topic-repl Related to the interactive shell label May 23, 2024
@JelleZijlstraJelleZijlstra mentioned this pull request May 28, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossumgvanrossumgvanrossum approved these changes

@sobolevnsobolevnsobolevn approved these changes

@willingcwillingcAwaiting requested review from willingcwillingc is a code owner

Assignees

No one assigned

Labels

skip newstopic-replRelated to the interactive shell

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Eclips4@gvanrossum@sobolevn@ambv