Skip to content

gh-118824: Remove deprecated master_open and slave_open from pty#118826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sobolevn merged 5 commits into from
May 28, 2024
Merged

gh-118824: Remove deprecated master_open and slave_open from pty#118826

sobolevn merged 5 commits into from
May 28, 2024

Conversation

@sobolevn
Copy link
Member

@sobolevnsobolevn commented May 9, 2024•
edited by github-actions bot
Loading

@sobolevnsobolevn requested a review from gpsheadMay 9, 2024 08:52
@bedevere-appbedevere-appbot mentioned this pull request May 9, 2024
Closed
ronaldoussoren
ronaldoussoren reviewed May 9, 2024
View reviewed changes
hugovk
hugovk reviewed May 9, 2024
View reviewed changes
hugovk
hugovk reviewed May 26, 2024
View reviewed changes
sobolevnand others added 2 commits May 28, 2024 13:52
@sobolevn@hugovk
Apply suggestions from code review
c73b325
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@sobolevn
Merge branch 'main' into issue-118824
7079349
hugovk
hugovk approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@sobolevnsobolevn merged commit f912e5a into python:mainMay 28, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@sobolevn@hugovk@estyxx
pythongh-118824: Remove deprecatedmaster_openandslave_openfro…
9fe427c
…m `pty` (python#118826) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
ambv
ambv reviewed Sep 24, 2024
View reviewed changes
Lib/pty.py
exceptImportError:
returnmaster_fd, slave_fd
try:
ioctl(result, I_PUSH, "ptem")
Copy link
Contributor

@ambvambvSep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

result is a NameError now.

Copy link
MemberAuthor

@sobolevnsobolevnSep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in #124406

@sobolevnsobolevn mentioned this pull request Sep 24, 2024
Closed
@hauntsaninjahauntsaninja mentioned this pull request Sep 24, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambvambvambv left review comments

@ronaldoussorenronaldoussorenronaldoussoren left review comments

@hugovkhugovkhugovk approved these changes

@gpsheadgpsheadAwaiting requested review from gpshead

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sobolevn@ambv@ronaldoussoren@hugovk