Skip to content

gh-117657: Fix data races reported by TSAN on interp->threads.main#118865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
colesbury merged 4 commits into from
May 10, 2024
Merged

gh-117657: Fix data races reported by TSAN on interp->threads.main#118865

colesbury merged 4 commits into from
May 10, 2024

Conversation

@mpage
Copy link
Contributor

@mpagempage commented May 9, 2024•
edited by bedevere-app bot
Loading

@mpage
Fix data races reported by TSAN on interp->threads.main
50cf12b
Use relaxed loads/stores when reading/writing to this field. This fixes races like https://gist.github.com/mpage/e07497ad8dd444a789ff306cb7996acc
@bedevere-appbedevere-appbot mentioned this pull request May 9, 2024
Closed
@mpagempage requested a review from colesburyMay 9, 2024 20:24
@mpagempage marked this pull request as ready for review May 9, 2024 20:24
colesbury
colesbury approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@colesburycolesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

Can we remove any TSan suppressions after this change? I'm merging #118722 now, so you might want to wait a little bit and then merge main into this PR.

@colesburycolesbury added the needs backport to 3.13 bugs and security fixes label May 9, 2024
@mpage
Copy link
ContributorAuthor

mpage commented May 9, 2024

Sounds good. I'll wait until you merge #118722 then update this PR to remove the appropriate suppressions.

@colesburycolesbury merged commit 22d5185 into python:mainMay 10, 2024
@miss-islington-app
Copy link

miss-islington-appbot commented May 10, 2024

Thanks @mpage for the PR, and @colesbury for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 10, 2024
@mpage@miss-islington
pythongh-117657: Fix data races reported by TSAN on `interp->threads.…
6d5e97f
…main` (pythonGH-118865) Use relaxed loads/stores when reading/writing to this field. (cherry picked from commit 22d5185) Co-authored-by: mpage <mpage@meta.com>
@bedevere-app
Copy link

bedevere-appbot commented May 10, 2024

GH-118904 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label May 10, 2024
colesbury pushed a commit that referenced this pull request May 10, 2024
@miss-islington@mpage
[3.13]gh-117657: Fix data races reported by TSAN on `interp->threads…
4480dd8
….main` (GH-118865) (#118904) Use relaxed loads/stores when reading/writing to this field. (cherry picked from commit 22d5185) Co-authored-by: mpage <mpage@meta.com>
@JelleZijlstraJelleZijlstra mentioned this pull request May 28, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesburycolesburycolesbury approved these changes

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mpage@colesbury