[3.13] gh-117657: Replace TSAN suppresions with more specific rules (GH-118722)#118870
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ythonGH-118722) Using `race:` filters out warnings if the function appears anywhere in the stack trace. This can hide a lot of unrelated warnings, especially for a function like `_PyEval_EvalFrameDefault`, which is somewhere on the stack more often than not. Change all free-threaded suppressions to `race_top:`, which only matches the top frame, and add any new suppressions this exposes. (cherry picked from commit 98ff3f6) Co-authored-by: Brett Simmers <swtaarrs@users.noreply.github.com>
This was referenced May 9, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
race:filters out warnings if the function appears anywhere inthe stack trace. This can hide a lot of unrelated warnings, especially
for a function like
_PyEval_EvalFrameDefault, which is somewhere onthe stack more often than not.
Change all free-threaded suppressions to
race_top:, which only matchesthe top frame, and add any new suppressions this exposes.
(cherry picked from commit 98ff3f6)
Co-authored-by: Brett Simmers swtaarrs@users.noreply.github.com