gh-118877: Fix AssertionError crash in pyrepl#118936
Merged
+25 −4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
A crash of the new pyrepl was triggered by pressing up arrow when tab completion menu was displayed.
2 tasks
Thanks @danielhollas for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2024
(cherry picked from commit c0d81b2) Co-authored-by: Daniel Hollas <daniel.hollas@bristol.ac.uk>
GH-119363 is a backport of this pull request to the 3.13 branch. |
lysnikolaou pushed a commit that referenced this pull request May 22, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A crash of the new pyrepl was triggered by pressing up arrow when tab completion menu was displayed. Fixes#118877
While this simple fix does the trick, as @lysnikolaou mentioned in a #118877 (comment), there are other issues with how arrows interact with tab completions menu, so a more holistic fix might be needed eventually.
I am hoping this is still useful to at least stop interpreter from crashing. Also the added test can serve is as a regression test.
(it took me quite a while to figure out how to write the test, suggestions how to improve it are welcome 🙏 )
AssertionErroroccurs using 3.130b1 interactive mode when pressed tab and up arrow #118877