Move the comment to the right place where it used to be#119085
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
In pythonGH-116206, the comment about moving reachable objects to next generation got moved from its original place to a place where there is no code below it. This PR puts it back where the actual movement of rechable objects happen to the next generation.
ContributorAuthor
abhinav-upadhyay commented May 18, 2024
Can this be merged, or it requires something more? |
ContributorAuthor
abhinav-upadhyay commented May 27, 2024
@markshannon Maybe you need to review this? |
Contributor
sergey-miryanov commented Aug 7, 2025
Member
nascheme commented Aug 7, 2025
LGTM. I've enabled auto-merge after resolving the merge conflict. |
nascheme merged commit e3ad900 into python:main 40 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
In pythonGH-116206, the comment about moving reachable objects to next generation got moved from its original place to a place where there is no code below it. Put the comment back to where the actual movement of reachable objects happens.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In GH-116206, the comment about moving reachable objects to next generation got moved from its original place to a place where there is no code below it.
This PR puts it back where the actual movement of reachable objects happen to the next generation.
(I don't think this is a cosmetic change. The purpose of the comment is to document the code underneath it. Either the code and comments have to be in sync, or the comments need to be fixed to reflect the current reality. In this case, the comment is not quite at the right place, misleading for anyone new reading it or changing that code.)