Skip to content

Conversation

@rhettinger
Copy link
Contributor

@rhettingerrhettinger commented May 18, 2024

  • Rename variable from empty_link to the more descriptive `shared_link'.
  • Hoist the try/except outside of the inner loop.

📚 Documentation preview 📚: https://cpython-previews--119135.org.readthedocs.build/

@rhettingerrhettinger added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels May 18, 2024
@rhettingerrhettinger merged commit 81c3130 into python:mainMay 18, 2024
@miss-islington-app
Copy link

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@rhettingerrhettinger deleted the itertools_docs branch May 18, 2024 06:32
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 18, 2024
(cherry picked from commit 81c3130) Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 18, 2024
(cherry picked from commit 81c3130) Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
@bedevere-app
Copy link

GH-119136 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label May 18, 2024
@bedevere-app
Copy link

GH-119137 is a backport of this pull request to the 3.12 branch.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docsDocumentation in the Doc dirskip issueskip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@rhettinger