Skip to content

Conversation

@jacobtylerwalls
Copy link
Contributor

@jacobtylerwallsjacobtylerwalls commented May 18, 2024

Deprecation took place in d78742a (3.5)


📚 Documentation preview 📚: https://cpython-previews--119151.org.readthedocs.build/

@bedevere-appbedevere-appbot added docs Documentation in the Doc dir skip news awaiting review labels May 18, 2024
Copy link
Contributor

@blaisepblaisep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch,
...there is a directive called .. deprecated:: which might be useful here.

* Undocumented :meth:`TestLoader.loadTestsFromModule
<unittest.TestLoader.loadTestsFromModule>` parameter *use_load_tests*
(deprecated and ignored since Python 3.2).
(deprecated and ignored since Python 3.5).
Copy link
Contributor

@blaisepblaisepMay 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch thank you.
Could you put this in a .. deprecated:: 3.5 directive ?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look. I only see uses of that directive in the actual documentation relating to the method itself, not here in the changelog. I'm reluctant to add the first such directive in this /whatsnew directory.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. I guess this may be impacted by the bigger topic mentioned in #109843 (comment) having to do with moving deprecation and removal items out of news.

(deprecated and ignored since Python 3.5).

* An alias of the :class:`~unittest.TextTestResult` class:
``_TextTestResult`` (deprecated in Python 3.2).
Copy link
Contributor

@blaisepblaisepMay 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might also be a candidate for ..deprecated :: 3.2

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@miss-islington-app
Copy link

Thanks @jacobtylerwalls for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 22, 2024
…119151) Deprecation took place in d78742a (3.5) (cherry picked from commit aee8f03) Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 22, 2024
…119151) Deprecation took place in d78742a (3.5) (cherry picked from commit aee8f03) Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
@bedevere-app
Copy link

GH-119386 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label May 22, 2024
@bedevere-app
Copy link

GH-119387 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12 only security fixes label May 22, 2024
serhiy-storchaka pushed a commit that referenced this pull request May 22, 2024
…-119151) (GH-119387) Deprecation took place in d78742a (3.5) (cherry picked from commit aee8f03) Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
serhiy-storchaka pushed a commit that referenced this pull request May 22, 2024
…-119151) (GH-119386) Deprecation took place in d78742a (3.5) (cherry picked from commit aee8f03) Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
@jacobtylerwallsjacobtylerwalls deleted the fix-deprecation-reference branch May 22, 2024 10:14
@JelleZijlstraJelleZijlstra mentioned this pull request May 28, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docsDocumentation in the Doc dirskip issueskip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jacobtylerwalls@blaisep@serhiy-storchaka