gh-118692: Avoid creating unnecessary StopIteration instances for monitoring#119216
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
markshannon requested changes May 20, 2024
Member
markshannon left a comment
markshannon left a comment There was a problem hiding this comment.
Possible NULL dereference needs fixing. Looks good, otherwise.
Uh oh!
There was an error while loading. Please reload this page.
When you're done making the requested changes, leave the comment: |
MemberAuthor
iritkatriel commented May 21, 2024
I have made the requested changes; please review again. |
Thanks for making the requested changes! @markshannon: please review the changes made to this pull request. |
markshannon approved these changes May 21, 2024
Contributor
scoder commented May 24, 2024
This needs backporting to 3.13. |
Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 24, 2024
…or monitoring (pythonGH-119216) (cherry picked from commit 6e9863d) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
GH-119497 is a backport of this pull request to the 3.13 branch. |
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#118692.
📚 Documentation preview 📚: https://cpython-previews--119216.org.readthedocs.build/