Skip to content

gh-119357: Increase test coverage for keymap in _pyrepl#119358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ambv merged 4 commits into from
May 22, 2024
Merged

gh-119357: Increase test coverage for keymap in _pyrepl #119358

ambv merged 4 commits into from
May 22, 2024

Conversation

@eugenetriguba
Copy link
Contributor

@eugenetrigubaeugenetriguba commented May 21, 2024•
edited by bedevere-app bot
Loading

This PR adds a few test cases to the keymap module tests to increase the coverage.

Lib/_pyrepl/keymap.py 79 0 48 0 100%

@bedevere-appbedevere-appbot mentioned this pull request May 21, 2024
Closed
eugenetriguba
eugenetriguba commented May 21, 2024
View reviewed changes
Lib/_pyrepl/completing_reader.py
# types
Command=commands.Command
ifFalse:
from .typesimportCallback, SimpleContextManager, KeySpec, CommandName
Copy link
ContributorAuthor

@eugenetrigubaeugenetrigubaMay 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: these two aren't used

@eugenetriguba
Copy link
ContributorAuthor

eugenetriguba commented May 21, 2024

I'd think this PR can skip news

@ambvambv added skip news topic-repl Related to the interactive shell labels May 21, 2024
ambv
ambv reviewed May 21, 2024
View reviewed changes
@eugenetriguba
Copy link
ContributorAuthor

eugenetriguba commented May 21, 2024•
edited
Loading

@ambv beat me to it, thanks for the fix 🙂 I'll update the issue to more clearly encompass all of PyREPL instead of just the keymap module. Thanks for the feedback, let me know if you had any other requested changes!

@ambvambv merged commit 73ab83b into python:mainMay 22, 2024
@lysnikolaoulysnikolaou added the needs backport to 3.13 bugs and security fixes label May 22, 2024
@miss-islington-app
Copy link

miss-islington-appbot commented May 22, 2024

Thanks @eugenetriguba for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-appbot commented May 22, 2024

Sorry, @eugenetriguba and @ambv, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 73ab83b27f105a4509046ce26e35f20d66625195 3.13

lysnikolaou pushed a commit to lysnikolaou/cpython that referenced this pull request May 22, 2024
@eugenetriguba@ambv@lysnikolaou
[3.13]pythongh-119357: Increase test coverage for keymap in _pyrepl (p…
f509295
…ythonGH-119358) (cherry picked from commit 73ab83b) Co-authored-by: Eugene Triguba <eugenetriguba@gmail.com> Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@bedevere-app
Copy link

bedevere-appbot commented May 22, 2024

GH-119414 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label May 22, 2024
ambv added a commit that referenced this pull request May 22, 2024
@lysnikolaou@eugenetriguba@ambv
[3.13]gh-119357: Increase test coverage for keymap in _pyrepl (GH-11…
e6e4efc
…9358) (#119414) (cherry picked from commit 73ab83b) Co-authored-by: Eugene Triguba <eugenetriguba@gmail.com> Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@JelleZijlstraJelleZijlstra mentioned this pull request May 28, 2024
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@eugenetriguba@ambv@estyxx
pythongh-119357: Increase test coverage for keymap in _pyrepl (python…
78a44a9
…#119358) Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambvambvambv left review comments

Assignees

@ambvambv

Labels

skip newstopic-replRelated to the interactive shell

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eugenetriguba@ambv@lysnikolaou