Skip to content

Conversation

@xyb
Copy link
Contributor

@xybxyb commented May 23, 2024

No description provided.

Copy link
Contributor

@blaisepblaisep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @xyb , thank you very much for these corrections, they look very good. I will ask @CAM-Gerlach to consider merging this PR because it looks clean.

@blaisep
Copy link
Contributor

@CAM-Gerlach , this PR will need labels for skip-issue (and maybe skip-news). I don't think I can add those labels myself.

@xyb
Copy link
ContributorAuthor

xyb commented May 27, 2024

@CAM-Gerlach@hauntsaninja@serhiy-storchaka@AlexWaygood Please take a look, thank you!

@hugovkhugovk merged commit 5ef5622 into python:mainMay 27, 2024
@miss-islington-app
Copy link

Thanks @xyb for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 27, 2024
(cherry picked from commit 5ef5622) Co-authored-by: Xie Yanbo <xieyanbo@gmail.com>
@bedevere-app
Copy link

GH-119597 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 27, 2024
(cherry picked from commit 5ef5622) Co-authored-by: Xie Yanbo <xieyanbo@gmail.com>
@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label May 27, 2024
@bedevere-app
Copy link

GH-119598 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12 only security fixes label May 27, 2024
@hugovk
Copy link
Member

@CAM-Gerlach@hauntsaninja@serhiy-storchaka@AlexWaygood Please take a look, thank you!

Thanks for the PR, but no need to ping four core devs about it 👍

@xybxyb deleted the fixtypos branch May 27, 2024 08:02
hugovk pushed a commit that referenced this pull request May 27, 2024
Co-authored-by: Xie Yanbo <xieyanbo@gmail.com>
hugovk pushed a commit that referenced this pull request May 27, 2024
Co-authored-by: Xie Yanbo <xieyanbo@gmail.com>
@JelleZijlstraJelleZijlstra mentioned this pull request May 28, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@xyb@blaisep@hugovk