Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 33.9k
Update README and layout.html from 3.13 to 3.14#119539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
Wulian233 commented May 25, 2024 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Wulian233 commented May 25, 2024 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Oh NO. There was an accident, my last not merge PR changed files was added here |
nineteendo commented May 25, 2024
I think we can add skip issue and news. |
Wulian233 commented May 25, 2024 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
I'm not sure layout.html should keep 3.13(dev), I deleted |
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
Wulian233 commented May 25, 2024
nineteendo commented May 25, 2024
You can wait to see which pull request is merged first. |
hugovk commented May 25, 2024
Please delete unittestgui.py from the PR, or I can do it for you if you like?
It makes more sense to add 3.14 to layout.html here, so #119541 is just moving code, not adding to it. We can resolve conflicts later. |
Wulian233 commented May 25, 2024 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Can you help me delete the unittestgui.py, thx |
hugovk commented May 25, 2024
Done, or rather what was needed was to re-add the |
nineteendo commented May 25, 2024
Ah wow, |
terryjreedy commented May 25, 2024
Remove idlelib/help.html from this PR. The change is wrong. I presume you can just revert the corresponding commit. I believe your DPI commit was included because you made the change to main rather than a dpi branch. |
Wulian233 commented May 25, 2024 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Yes I made the change to main instead dpi branch:( and I have revert the help.html |
terryjreedy commented May 26, 2024
@hugovk Can you either handle this or ping someone else? |
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hugovk left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Skip issue and news
📚 Documentation preview 📚: https://cpython-previews--119539.org.readthedocs.build/