Skip to content

Conversation

@jaraco
Copy link
Member

@jaracojaraco commented May 27, 2024

@jaracojaraco requested a review from Yhg1sMay 27, 2024 01:53
@jaraco
Copy link
MemberAuthor

jaraco commented May 27, 2024

@Yhg1s - I've tagged you on the review as I'd like your opinion on whether this qualifies as a bugfix for Python 3.12. It's considered a security issue by some (that's how it was reported to me), but since the issue was introduced in 3.12, there's no need to backport it to security-only Pythons.

Are you okay with including this change as a bugfix for Python 3.12 (and by extension 3.13), or would you rather keep the "always false" behavior for 3.12 and 3.13?

@jaracojaraco merged commit 42a34dd into python:mainJun 3, 2024
@miss-islington-app
Copy link

Thanks @jaraco for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@jaracojaraco deleted the zipfile-is-symlink branch June 3, 2024 15:13
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 3, 2024
…thonGH-119591) (cherry picked from commit 42a34dd) Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
@miss-islington-app
Copy link

Sorry, @jaraco, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 42a34ddb0b63e638905b01e17a7254623a0de427 3.12 

@bedevere-app
Copy link

GH-119985 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label Jun 3, 2024
@bedevere-app
Copy link

GH-119988 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12 only security fixes label Jun 3, 2024
mliezun pushed a commit to mliezun/cpython that referenced this pull request Jun 3, 2024
jaraco added a commit that referenced this pull request Jun 4, 2024
…H-119591) (#119985) gh-119588: Implement zipfile.Path.is_symlink (zipp 3.19.0). (GH-119591) (cherry picked from commit 42a34dd) Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
barneygale pushed a commit to barneygale/cpython that referenced this pull request Jun 5, 2024
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@jaraco