gh-119659: Move @no_rerun to test.support#119660
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
sobolevn requested review from abalkin, brettcannon, ericsnowcurrently, ncoghlan, pganssle and warsaw as code owners
Eclips4 approved these changes May 28, 2024
ericsnowcurrently approved these changes May 28, 2024
Member
ericsnowcurrently left a comment
ericsnowcurrently left a comment There was a problem hiding this comment.
LGTM
Do note that we also use a form of this in TestStaticTypes, in Lib/test/test_capi/test_misc.py. It may be worth adapting that to use @no_rerun(), but I'm not opposed to it being done separately (to keep this PR simpler).
MemberAuthor
sobolevn commented May 28, 2024
Thanks! I will send a second PR with that. I will need to test the refactored code, while this one is a no-brainer. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no_rerunfromtest_importanddatetimetestertotest.support#119659