Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
bpo-31904: Add cross-build support for VxWorks RTOS#11968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
pxinwr commented Feb 21, 2019 • edited by bedevere-bot
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by bedevere-bot
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
bedevere-bot commented Feb 25, 2019
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
pxinwr commented Feb 26, 2019
I have made the requested changes; please review again |
bedevere-bot commented Feb 26, 2019
Thanks for making the requested changes! @vstinner: please review the changes made to this pull request. |
vstinner left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except of 2 minor changes: please fix NEWS entry and variable name.
setup.py Outdated
| return sys.platform | ||
| host_platform = get_platform() | ||
| _vxworks = ('vxworks' in host_platform) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename the variable to VXWORKS to better distinguish local and global variables in functions below.
By the way, I would also prefer to rename host_platform to HOST_PLATFORM for the same reason, but it should be done in a separated PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm: all the variables that are not supposed to be modified should be defined as constants, right? If this is true, besides host_platform, cross_compiling is another one to fix. I looked through PEP-8 but didn't find the guidance.
Uh oh!
There was an error while loading. Please reload this page.
pxinwr commented Feb 27, 2019 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Out of curiosity, does CPython run LGTM analysis as well? |
vstinner commented Feb 27, 2019
Are you talking about lgtm.com? I know that Mark Shannon is working for this company, and I know that CPython is scanned by lgtm.com. Sadly, I never looked at it. |
vstinner commented Feb 27, 2019
Ah, I found it: https://lgtm.com/projects/g/python/cpython/ |
vstinner commented Feb 27, 2019
Thanks @pxinwr, I merged your PR ;-) |
bedevere-bot commented Feb 27, 2019
|
bedevere-bot commented Feb 27, 2019
|
bedevere-bot commented Feb 27, 2019
|
bedevere-bot commented Feb 27, 2019
|
bedevere-bot commented Feb 27, 2019
|
bedevere-bot commented Feb 27, 2019
|
bedevere-bot commented Feb 27, 2019
|
vstinner commented Feb 27, 2019
I wrote PR #12068 as a follow-up of this PR. |
vstinner commented Feb 27, 2019
About buildbot failures: I guess that most if not all of them are caused by the FTP server issue, https://bugs.python.org/issue36131 |
This PR enables cpython build system to cross-build for VxWorks RTOS. More and full support on modules for VxWorks will continuously be added by the coming PRs.
VxWorks is a product developed and owned by Wind River. For VxWorks introduction or more details, go to https://www.windriver.com/products/vxworks/
Wind River will have a dedicated engineering team to contribute to the support as maintainers.
We already have a working buildbot worker internally, but has not bound to master. We will check the process for the buildbot, then add it.
https://bugs.python.org/issue31904