Skip to content

gh-119740: Remove deprecated trunc delegation#119743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mdickinson merged 18 commits into from
Jun 2, 2024
Merged

gh-119740: Remove deprecated trunc delegation #119743

mdickinson merged 18 commits into from
Jun 2, 2024

Conversation

@mdickinson
Copy link
Member

@mdickinsonmdickinson commented May 29, 2024•
edited
Loading

This PR removes the delegation of int to the __trunc__ special method: int will now only delegate to __int__ and __index__ (in that order). __trunc__ continues to exist, but its sole purpose is to support math.trunc.

📚 Documentation preview 📚: https://cpython-previews--119743.org.readthedocs.build/

@bedevere-appbedevere-appbot mentioned this pull request May 29, 2024
Closed
serhiy-storchaka
serhiy-storchaka reviewed May 29, 2024
View reviewed changes
serhiy-storchaka
serhiy-storchaka approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I would prefer to merge this after #119687, to make backporting of #119687 easier.

picnixz
picnixz reviewed May 30, 2024
View reviewed changes
@mdickinson
Copy link
MemberAuthor

mdickinson commented May 31, 2024

Thanks for the comments; I'll address before merging (but it may take me a few days to get to it).

@mdickinson
Copy link
MemberAuthor

mdickinson commented May 31, 2024

But I would prefer to merge this after #119687, to make backporting of #119687 easier.

Definitely! Looks like #119687 has gone in now; I'll update for conflicts when I get the chance.

mdickinsonand others added 2 commits June 2, 2024 09:34
@mdickinson@picnixz
More direct wording
1c2a638
Co-authored-by: Bénédikt Tran <[email protected]>
@mdickinson@picnixz
Grammar nit
26d5833
Co-authored-by: Bénédikt Tran <[email protected]>
mdickinson
mdickinson commented Jun 2, 2024
View reviewed changes
mdickinson
mdickinson commented Jun 2, 2024
View reviewed changes
@mdickinson
Copy link
MemberAuthor

mdickinson commented Jun 2, 2024

Updating for merge conflicts ...

@mdickinsonmdickinson merged commit f79ffc8 into python:mainJun 2, 2024
barneygale pushed a commit to barneygale/cpython that referenced this pull request Jun 5, 2024
@mdickinson@picnixz
@serhiy-storchaka@barneygale
pythongh-119740: Remove deprecated trunc delegation (python#119743)
c0c837a
Remove the delegation of `int` to the `__trunc__` special method: `int` will now only delegate to `__int__` and `__index__` (in that order). `__trunc__` continues to exist, but its sole purpose is to support `math.trunc`. --------- Co-authored-by: Bénédikt Tran <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@mdickinson@picnixz
@serhiy-storchaka@noahbkim
pythongh-119740: Remove deprecated trunc delegation (python#119743)
327e81d
Remove the delegation of `int` to the `__trunc__` special method: `int` will now only delegate to `__int__` and `__index__` (in that order). `__trunc__` continues to exist, but its sole purpose is to support `math.trunc`. --------- Co-authored-by: Bénédikt Tran <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@mdickinson@picnixz
@serhiy-storchaka@estyxx
pythongh-119740: Remove deprecated trunc delegation (python#119743)
8bb4fb3
Remove the delegation of `int` to the `__trunc__` special method: `int` will now only delegate to `__int__` and `__index__` (in that order). `__trunc__` continues to exist, but its sole purpose is to support `math.trunc`. --------- Co-authored-by: Bénédikt Tran <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixzpicnixzpicnixz left review comments

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mdickinson@serhiy-storchaka@picnixz