[3.13] gh-109218: Refactor tests for the complex() constructor (GH-119635)#119795
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…GH-119635) * Share common classes. * Use exactly representable floats and exact tests. * Check the sign of zero components. * Remove duplicated tests (mostly left after merging int and long). * Reorder tests in more consistent way. * Test more error messages. * Add tests for missed cases. (cherry picked from commit bf098d4) Co-authored-by: Serhiy Storchaka <[email protected]>
This was referenced May 30, 2024
Member
@serhiy-storchaka You enabled auto-merge on this, but for some reason the "Tests / Windows (free-threading) / build (arm64)" CI failed, so it didn't merge. Unfortunately the logs have since expired, maybe it was just a temporary thing. I've merged in I've also disabled auto-merge, because 3.13 is in the RC phase and I'll let you make a fresh decision whether it can be merged now. |
Member
hugovk commented Aug 9, 2024
CI passed now. I think it probably could go into 3.13, it's only changing test files. |
Member
serhiy-storchaka commented Aug 9, 2024
Thank you @hugovk for noticing this. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit bf098d4)
Co-authored-by: Serhiy Storchaka [email protected]