Skip to content

Conversation

@vstinner
Copy link
Member

@vstinnervstinner commented May 31, 2024

Don't attempt to load pyrepl Windows console if platforms others than Windows. For example, the import can fail if ctypes is missing.

@bedevere-appbedevere-appbot added tests Tests in the Lib/test dir awaiting core review labels May 31, 2024
@bedevere-appbedevere-appbot mentioned this pull request May 31, 2024
7 tasks
@vstinnervstinner changed the title gh-111201: Skip pyperl Windows tests earliergh-111201: Skip pyrepl Windows tests earlierMay 31, 2024
@vstinner
Copy link
MemberAuthor

Example of failiure on FreeBSD where _ctypes extension is missing: https://buildbot.python.org/all/#/builders/1232/builds/2462

0:10:59 load avg: 3.41 [403/478/1] test_pyrepl failed (uncaught exception) Failed to import test module: test.test_pyrepl.test_windows_console Traceback (most recent call last): File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/unittest/loader.py", line 396, in _find_test_path module = self._get_module_from_name(name) File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/unittest/loader.py", line 339, in _get_module_from_name __import__(name) ~~~~~~~~~~^^^^^^ File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/test/test_pyrepl/test_windows_console.py", line 5, in <module> from _pyrepl.windows_console import ( ...<5 lines>... ) File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/_pyrepl/windows_console.py", line 30, in <module> import ctypes File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/ctypes/__init__.py", line 8, in <module> from _ctypes import Union, Structure, Array ModuleNotFoundError: No module named '_ctypes' test test_pyrepl crashed -- Traceback (most recent call last): File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/test/libregrtest/single.py", line 181, in _runtest_env_changed_exc _load_run_test(result, runtests) ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/test/libregrtest/single.py", line 138, in _load_run_test regrtest_runner(result, test_func, runtests) ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/test/libregrtest/single.py", line 91, in regrtest_runner test_result = test_func() File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/test/libregrtest/single.py", line 135, in test_func return run_unittest(test_mod) File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/test/libregrtest/single.py", line 35, in run_unittest raise Exception("errors while loading tests") Exception: errors while loading tests 

Don't attempt to load pyrepl Windows console if platforms others than Windows. For example, the import can fail if ctypes is missing.
@vstinnervstinner enabled auto-merge (squash) May 31, 2024 13:50
@vstinnervstinner merged commit 91601a5 into python:mainMay 31, 2024
@vstinnervstinner deleted the pyrepl_testwin branch May 31, 2024 14:06
@AlexWaygood
Copy link
Member

FYI, I think that that buildbot failure was already fixed an hour ago, in #119834

vstinner added a commit to vstinner/cpython that referenced this pull request Jun 1, 2024
Don't attempt to load pyrepl Windows console if platforms others than Windows. For example, the import can fail if ctypes is missing. (cherry picked from commit 91601a5)
@bedevere-app
Copy link

GH-119924 is a backport of this pull request to the 3.13 branch.

vstinner added a commit that referenced this pull request Jun 1, 2024
gh-111201: Skip pyrepl Windows tests earlier (#119848) Don't attempt to load pyrepl Windows console if platforms others than Windows. For example, the import can fail if ctypes is missing. (cherry picked from commit 91601a5)
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
Don't attempt to load pyrepl Windows console if platforms others than Windows. For example, the import can fail if ctypes is missing.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Don't attempt to load pyrepl Windows console if platforms others than Windows. For example, the import can fail if ctypes is missing.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner@AlexWaygood@pablogsal